make transaction core input rules validation use U64Ratio #3224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeck88
requested review from
NotGyro and
awygle
and removed request for
a team
cbeck88
force-pushed
the
make-transaction-core-use-u64-ratio
branch
from
1defee4
to
5cf5601
Compare
cbeck88
added
tech-debt
wjuan-mob
approved these changes
Mar 14, 2023
cbeck88
force-pushed
the
make-transaction-core-use-u64-ratio
branch
from
eeefee5
to
538c9ac
Compare
|
rebased on master edit: now on james' cargo lock fix PR |
cbeck88
force-pushed
the
make-transaction-core-use-u64-ratio
branch
from
538c9ac
to
cb0a49b
Compare
|
I think there are still some cargo issues in the various enclaves to fix, will do that next |
this still looks wrong to me, but i'm done fighting cargo for tonight
cbeck88
force-pushed
the
make-transaction-core-use-u64-ratio
branch
from
3789141
to
6c62030
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the changes in #3214 around DRY'ing up the u64 / u128 arithmetic stuff.
I don't think we should merge this in release/v4.1 since we can't modify the enclave in 4.1 anyways, I think we should just do this in master later. But this at least shows the direction of the U64Ratio stuff.