mobilecoind: fix a bug in swap generation #3232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SignedContingentInputBuilder` does not know the TxOut global indices of the ring elements, they usually aren't supplied to it unless merkle proofs of membership were supplied to it. It usually ends up setting `tx_out_global_indices` to a list of zeroes, and it falls to the counterparty to find proofs of membership. I forgot to do this in `generate_swap_impl`, so `mobilecoind` was leaving `tx_out_global_indices` with an incorrect setting. This commit fixes it and adds a test.
cbeck88
added
bug
eranrund
approved these changes
Mar 13, 2023
wjuan-mob
reviewed
Mar 13, 2023
| .map_err(|err| Error::TxBuild(format!("build tx failed: {err}"))) | ||
| .map_err(|err| Error::TxBuild(format!("build tx failed: {err}")))?; | ||
|
|
||
| result.tx_out_global_indices = global_indices; |
There was a problem hiding this comment.
Do we need to sort global_indices first?
There was a problem hiding this comment.
i think they are supposed to correspond in order to the TxOut's in the ring
samdealy
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this bug was introduced a few days ago here: #3212