Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp field to Block #3734

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Nov 20, 2023

The Block now has a timestamp field. This field is meant to
represent a consensed timestamp for the block that all the nodes will
sign.

Currently the timestamp is not being populated. The logic to properly
set the timestamp is expected to come in a follow on PR.

@nick-mobilecoin
Copy link
Collaborator Author

nick-mobilecoin commented Nov 20, 2023

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nick-mobilecoin and the rest of your teammates on Graphite Graphite

ledger/db/src/test_utils/mod.rs Outdated Show resolved Hide resolved
The `Block` now has a `timestamp` field. This field is meant to
represent a consensed timestamp for the block that all the nodes will
sign.

Currently the timestamp is *not* being populated. The logic to properly
set the timestamp is expected to come in a follow on PR.
Previously one could set the `Block.timestamp` to something other than 0
when the block version didn't support timestamps. Now the timestamp will
be set to 0 if the block version doesn't support timestamps
Currently the logic to populate the timestamp has not been implemented
thus it's not practical to enforce the timestamp value at this time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants