FRONTEND-4243 :: Feature :: Harmony-typescript NetworkDataSource

[urijp]

Asana task link:
https://app.asana.com/0/1109863238977521/1202775968264243/f

Pull request information:
This PR contains de implementation of the generic network data source. The relevant changes here are:

• NetworkDataSource implementation
• NetworkQuery implementation
• HttpRequestBuilder refactor, removing the mapping within this class to always use DataSourceMapper
• Creation of two helpers to provide DefaultNetworkDataSourceMapper and DefaultNetworkDataSourceArrayMapper.

[lucianosantana]

@orioljp why is it still flagged as WIP ? What is missing?

[urijp]

@lucianosantana yes, it's in progress because IMO we need an example or proper testing and this is not done mainly because I want to validate the approach with all of you before facing it. Could you check it @lucianosantana @doup @joselufo ?

[lucianosantana]

@lucianosantana yes, it's in progress because IMO we need an example or proper testing and this is not done mainly because I want to validate the approach with all of you before facing it. Could you check it @lucianosantana @doup @joselufo ?

The approach seems correct to me.

[joselufo]

I had a call with @orioljp, and I think the approach is correct. It has some differences with the Kotlin and Swift implementation, but its development makes sense.

[doup]

Looks good in general, I've put "few" comments (🙏); and there are a couple of silly bugs. Maybe it would be nice to see some usage examples.

[urijp]

No problem, I appreciate it, as commented, it's a WIP and needs a deeper revision and testing, but your comments are useful, even apart from that, I need to add more things, so I'll ask for another check next week.

[orioljp]

@lucianosantana @doup @joselufo @Alex-DA now you can check the whole PR, it's ready to be merged

[doup]

Just two things (I've put them as comments also):

• NetworkOneQuery should expose key (?)
• I would like to see how query subclassing looks like as I've the impression that it can be improved, but I might be wrong.

[doup]

@urijp I'm approving it, if you do further changes and want another review tell me (or use the sidebar "Re-request review").