-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IdTagInfo datatype instead of Dict for id_tag_info occurances #278
Use IdTagInfo datatype instead of Dict for id_tag_info occurances #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for taking a look. There's actually quite a few similar occurances in dataclasses where things like I'll have a PR to update those soon.. |
What happend to this ? I have it like this:
but instead should be something like:
Should the type be changed to |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Seems pretty correct PR, what is blocking it? |
Nothing blocks it from being merged. Thanks for the notification @diorcety |
The
Authorize.conf
message in the v1.6 spec defines what fields should be present for anIdTagInfo
. The dataclass for this already exists indatatypes.py
, as of the recently merged #250 PR.This PR makes use of it by importing the dataclass, and using it instead of the more losely typed
typing.Dict
.