V201/missing component and type enums #300 #487
Conversation
…enums-#300' into v201/missing-component-and-type-enums-#300
ocpp/v201/enums.py
Outdated
| OfflineQueuingSeverity = "OfflineQueuingSeverity" | ||
| MonitoringBase = "MonitoringBase" | ||
| MonitoringLevel = "MonitoringLevel" | ||
| ActiveMonitoringBase = "ActiveMonitoringBase" | ||
| ActiveMonitoringLevel = "ActiveMonitoringLevel" |
There was a problem hiding this comment.
Thanks - I've corrected this in fa72697
ocpp/v201/enums.py
Outdated
| ACPhaseSwitchingSupported = "ACPhaseSwitchingSupported" | ||
| Available = "Available" | ||
| Enabled = "Enabled" | ||
| Entries = "Entries" | ||
| ExternalControlSignalsEnabled = "ExternalControlSignalsEnabled" | ||
| LimitChangeSignificance = "LimitChangeSignificance" | ||
| NotifyChargingLimitWithSchedules = "NotifyChargingLimitWithSchedules" | ||
| PeriodsPerSchedule = "PeriodsPerSchedule" | ||
| Phases3to1 = "Phases3to1" | ||
| ProfileStackLevel = "ProfileStackLevel" | ||
| RateUnit = "RateUnit" |
There was a problem hiding this comment.
Thanks - I've corrected this in fa72697
|
@OrangeTux regarding #486 (review) - I used Appendices_CSV_v1.3 dm_components_vars.xlsx - this is referenced in OCPP 2.0.1 part 2 erratta v2.0 section 21.1 - where do you see the discrepancy? |
| vehicle_id_sensor = "VehicleIdSensor" | ||
|
|
||
|
|
||
| class GenericVariableName(str, Enum): |
There was a problem hiding this comment.
The .zip file containing the OCPP 2.0.1 contains Appendices_CSV_v1.3/variables.csv. This file contains defines 90 variables. This enum, however, contains 69 variants only. For example, AvailabilityState is missing. Can you add the missing variants?
| enabled = "Enabled" | ||
| life_time = "LifeTime" | ||
| policy = "Policy" | ||
| storage = "Storage" |
There was a problem hiding this comment.
I can't find variant storage in OCPP-2.0.1_part2_appendices_v13.pdf. Is this variant a mistake, or have you seen it listed in another document?
| disable_remote_authorization = "DisableRemoteAuthorization" | ||
|
|
||
|
|
||
| class CHAdeMOCtrlrVariableName(str, Enum): |
There was a problem hiding this comment.
Section 3.1.4 of OCPP-2.0.1_part2_appendices_v13.pdf lists more variants. For example, VehicleStatus. Which document did you use to create this enum?
| Variable names where the component type is CHAdeMOCtrlr | ||
| """ | ||
|
|
||
| selftest_active = "SelftestActive" |
There was a problem hiding this comment.
s/selftest_active/self_test_active
There was a problem hiding this comment.
In OCPP 2.0.1 Part 2 Errata v2 - CHAdeMOCtrlr SelftestActive - Self-test is active or self-test is started by setting to
true. - It appears to be hyphenated that is why it is combined as selftest and not self test
|
It seems that dm_components_vars.xlsx isn't matching the the written spec and the .csv files. |
|
Ok thanks, so for this I will revisit it using the .csv files, document and raise this with the OCA also |
# Conflicts: # CHANGELOG.md
|
@OrangeTux - ok, so after contacting the OCA, I have updated this to break the components into logical and physical components, I have also extended the docstrings to document where the variables were sourced from. I have generic variables both as complete (this is to align with the documents provided in appendices_CSV_v1.3.zip, dm_components_vars.csv) and split out for each component. The components have all variables listed in both OCPP 2.0.1 Part 2 Appendices and dm_components_vars.csv, so this results in additional variables. Hopefully, this makes things a little more clear. In addition, there is some variable names such as selftest_active_set = "SelftestActive(Set)" and count_height_in_chars = "Count[HeightInChars]" - I am not sure if this is the best way to represent these. I didn't reply to the individual comments as they may no longer be relevant with the changes. Looking forward to hear your thoughts. |
# Conflicts: # CHANGELOG.md
Co-authored-by: Markus Grunwald <97972764+tmh-grunwald-markus@users.noreply.github.com>
# Conflicts: # CHANGELOG.md # ocpp/v201/enums.py
Jared-Newell-Mobility
deleted the
v201/missing-component-and-type-enums-#300
branch
No description provided.