Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPP-2.0.1-add-additional-security-events-in-v1.3 #517

Conversation

Jared-Newell-Mobility
Copy link
Contributor

No description provided.

@Jared-Newell-Mobility Jared-Newell-Mobility changed the title the addition of missing events the addition of missing security events Nov 8, 2023
@Jared-Newell-Mobility Jared-Newell-Mobility changed the title the addition of missing security events OCPP-2.0.1-add-additional-security-events-in-v1.3 Nov 8, 2023
Copy link
Contributor

@tmh-grunwald-markus tmh-grunwald-markus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , change the comment at will.

"""Security Events as listed in Appendices (Appendix 1. Security Events)"""
"""
Security Events as listed in Appendices (Appendix 1. Security Events)
Updated to include v1.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks more like a commit message. Does it belong here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reduced it down to just state v.13

OrangeTux
OrangeTux previously approved these changes Dec 1, 2023
@Jared-Newell-Mobility Jared-Newell-Mobility merged commit 88e2006 into master Dec 6, 2023
6 checks passed
@Jared-Newell-Mobility Jared-Newell-Mobility deleted the OCPP-2.0.1-add-additional-security-events-in-v1.3 branch December 6, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants