Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization of 'ocpp_csms_url' #642

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Fix serialization of 'ocpp_csms_url' #642

merged 1 commit into from
Jun 3, 2024

Conversation

OrangeTux
Copy link
Collaborator

'camelCasing' ocpp_csms_url ends up as ocppCSMSURL.
This is wrong. The spec uses ocppCsmsUrl.

This commit fixes the conversion.

@OrangeTux
Copy link
Collaborator Author

@OSkrk Can you have a look as well?

OSkrk
OSkrk approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@OSkrk OSkrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@OrangeTux OrangeTux merged commit 0d90fd4 into master Jun 3, 2024
6 checks passed
@OrangeTux OrangeTux deleted the fix-csms-url-serializing branch June 3, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OSkrk OSkrk OSkrk approved these changes

@Jared-Newell-Mobility Jared-Newell-Mobility Awaiting requested review from Jared-Newell-Mobility

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrangeTux @OSkrk