A few bugs and minor improvements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stan1y
commented
Jun 16, 2014
stan1y
commented
- bug with SDL_free
- bug with lost mouseleave events
- access to button label
- focus & draw order control
|
Thanks for the patches! If you don't mind, I'd like to understand some of the things that you did before merging them. I'll be asking them in your commits :) |
make sure focus and mouseover don't point to destroyed widget
notify hovered widget in KW_DestroyWidget
- add widget->hidden flag and skip render callback if its true - add KW_SetWidgetHidden(KW_Widget * widget, KW_bool hidden)
- add KW_ScrollboxType enum - add KW_SetScrollboxType function - hide and disable input for scroller buttons based on currently set type
This reverts commit c84a94b. Conflicts: src/CMakeLists.txt
This reverts commit 9e4f38e. Conflicts: src/CMakeLists.txt src/KW_renderdriver.h src/KW_renderdriver_sdl2.h src/KW_widget_internal.h
This reverts commit 10e3c85. Conflicts: src/KW_renderdriver.h
This reverts commit 354b42a. Conflicts: src/KW_renderdriver_sdl2.c
This reverts commit c84a94b. Conflicts: src/CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.