Hr/download #132
Merged
Hr/download #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movchan74
reviewed
Jul 11, 2024
movchan74
reviewed
Jul 11, 2024
movchan74
reviewed
Jul 11, 2024
evanderiel
approved these changes
Jul 11, 2024
movchan74
requested changes
Jul 11, 2024
movchan74
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: Checking video length before downloading it
We can do other stuff like adding video's duration as part of metadata class.
Checking video duration inside the video_download (It requires to pass the max_length which currently a const for chat_with_video to the function) so it can raise error based on it)