Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started tutorial #133

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Getting started tutorial #133

merged 4 commits into from
Jul 12, 2024

Conversation

appoose
Copy link
Contributor

@appoose appoose commented Jul 11, 2024

Adding the notebook with the chat_with_video example that will be used for getting started video.

Merge branch 'main' into getting_started_tutorial
@appoose appoose marked this pull request as ready for review July 11, 2024 15:37
@appoose
Copy link
Contributor Author

appoose commented Jul 11, 2024

@movchan74 @ashwinnair14 @evanderiel Can you review this tutorial I wrote for the getting started video?

Copy link
Collaborator

@evanderiel evanderiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@movchan74
Copy link
Contributor

!pip install git+https://github.com/mobiusml/aana_sdk.git -qqqU

Shall we use pypi version instead?

@movchan74
Copy link
Contributor

I would suggest to add a link to integrations https://github.com/mobiusml/aana_sdk/blob/main/docs/integrations.md when you talk about Deployments.

@movchan74
Copy link
Contributor

movchan74 commented Jul 12, 2024

from aana.projects.chat_with_video.const import (
    asr_model_name,
    captioning_model_name,
    max_video_len,
)
from aana.projects.chat_with_video.utils import (
    generate_dialog,
)

consts and generate_dialog util function are imported from the chat_with_video project.

@appoose
Copy link
Contributor Author

appoose commented Jul 12, 2024

from aana.projects.chat_with_video.const import (
    asr_model_name,
    captioning_model_name,
    max_video_len,
)
from aana.projects.chat_with_video.utils import (
    generate_dialog,
)

consts and generate_dialog util function are imported from the chat_with_video project.

I will take it into the main notebook body.

Question: I find the models being defined at two places and potentially can cause issues. One in the .const and other in deploys configs

asr_model_name = "whisper_medium"
captioning_model_name = "hf_blip2_opt_2_7b"
max_video_len = 60 * 20  # 20 minutes


deployments = [
    {
        "name": "asr_deployment",
        "instance": whisper_medium_deployment,
    },    
    {
        "name": "captioning_deployment",
        "instance": hf_blip2_opt_2_7b_deployment,
    },
    {
        "name": "llm_deployment",
        "instance": internlm2_5_7b_chat_deployment,
    },
]

for deployment in deployments:
    aana_app.register_deployment(
        name=deployment["name"],
        instance=deployment["instance"],
    )

What might be a better way of handling this?

…ng all the functions from chat_with_video app into main notebook body
@movchan74
Copy link
Contributor

from aana.projects.chat_with_video.const import (
    asr_model_name,
    captioning_model_name,
    max_video_len,
)
from aana.projects.chat_with_video.utils import (
    generate_dialog,
)

consts and generate_dialog util function are imported from the chat_with_video project.

I will take it into the main notebook body.

Question: I find the models being defined at two places and potentially can cause issues. One in the .const and other in deploys configs

asr_model_name = "whisper_medium"
captioning_model_name = "hf_blip2_opt_2_7b"
max_video_len = 60 * 20  # 20 minutes


deployments = [
    {
        "name": "asr_deployment",
        "instance": whisper_medium_deployment,
    },    
    {
        "name": "captioning_deployment",
        "instance": hf_blip2_opt_2_7b_deployment,
    },
    {
        "name": "llm_deployment",
        "instance": internlm2_5_7b_chat_deployment,
    },
]

for deployment in deployments:
    aana_app.register_deployment(
        name=deployment["name"],
        instance=deployment["instance"],
    )

What might be a better way of handling this?

Model names from const are only used for the database ops. Maybe we can call deployments and get the model name from it in the future.

…out whisper-large ) but tests are not written for it
@appoose
Copy link
Contributor Author

appoose commented Jul 12, 2024 via email

@movchan74 movchan74 merged commit b1c0dd2 into main Jul 12, 2024
6 checks passed
@movchan74 movchan74 deleted the getting_started_tutorial branch July 12, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants