-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting started tutorial #133
Conversation
Merge branch 'main' into getting_started_tutorial
@movchan74 @ashwinnair14 @evanderiel Can you review this tutorial I wrote for the getting started video? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Shall we use pypi version instead? |
I would suggest to add a link to integrations https://github.com/mobiusml/aana_sdk/blob/main/docs/integrations.md when you talk about Deployments. |
from aana.projects.chat_with_video.const import (
asr_model_name,
captioning_model_name,
max_video_len,
)
from aana.projects.chat_with_video.utils import (
generate_dialog,
) consts and generate_dialog util function are imported from the chat_with_video project. |
I will take it into the main notebook body. Question: I find the models being defined at two places and potentially can cause issues. One in the .const and other in deploys configs
What might be a better way of handling this? |
…ng all the functions from chat_with_video app into main notebook body
Model names from const are only used for the database ops. Maybe we can call deployments and get the model name from it in the future. |
…out whisper-large ) but tests are not written for it
Okay, then I will keep as it is and update when we have facility to call deployments and get models names.
… On 12. Jul 2024, at 12:32, Aleksandr Movchan ***@***.***> wrote:
from aana.projects.chat_with_video.const import (
asr_model_name,
captioning_model_name,
max_video_len,
)
from aana.projects.chat_with_video.utils import (
generate_dialog,
)
consts and generate_dialog util function are imported from the chat_with_video project.
I will take it into the main notebook body.
Question: I find the models being defined at two places and potentially can cause issues. One in the .const and other in deploys configs
asr_model_name = "whisper_medium"
captioning_model_name = "hf_blip2_opt_2_7b"
max_video_len = 60 * 20 # 20 minutes
deployments = [
{
"name": "asr_deployment",
"instance": whisper_medium_deployment,
},
{
"name": "captioning_deployment",
"instance": hf_blip2_opt_2_7b_deployment,
},
{
"name": "llm_deployment",
"instance": internlm2_5_7b_chat_deployment,
},
]
for deployment in deployments:
aana_app.register_deployment(
name=deployment["name"],
instance=deployment["instance"],
)
What might be a better way of handling this?
Model names from const are only used for the database ops. Maybe we can call deployments and get the model name from it in the future.
—
Reply to this email directly, view it on GitHub <#133 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJL5SKZWVRGXDTGKWWCJZDZL6WFHAVCNFSM6AAAAABKXGMDW2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRVGI4TENRQGI>.
You are receiving this because you authored the thread.
|
Adding the notebook with the chat_with_video example that will be used for getting started video.