Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Index #135

Merged
merged 7 commits into from
Jul 12, 2024
Merged

Documentation Index #135

merged 7 commits into from
Jul 12, 2024

Conversation

movchan74
Copy link
Contributor

@movchan74 movchan74 commented Jul 12, 2024

Summary:
This update introduces a central index for documentation and improves the overall structure of the docs folder, making it easier for users to navigate and access information.

Key Changes:

  1. New README as docs index: Added a README file to the docs folder, serving as a central index for all documentation pages.
  2. Documentation restructure: Moved existing docs pages into a new /docs/pages subfolder for better organization.
  3. Logo relocation: Moved logo from the repo's root into docs and used raw.githubusercontent.com URL. It's cleaner. Using a direct URL will also allow displaying the logo on the PyPI page (now it's missing). Note: the link to the logo uses the URL's main branch, so it will only work once we merge the PR.
  4. Aana App Template Repo: Added link to aana app template repo.
  5. Cluster Setup: Moved from wiki and updated documentation on cluster setup.
  6. Documentation fixes: Corrected various minor issues and inaccuracies in the existing documentation.

@appoose
Copy link
Contributor

appoose commented Jul 12, 2024

  1. Can you also add https://github.com/mobiusml/aana_sdk/wiki/Cluster-Setup ( maybe move it out of wiki to docs ) and add a section on scaling up the SDK ?
  2. There are ways to monitor Ray cluster, and is not apparent. We should probably talk about it somewhere ( not in detail during this version )
  3. We should link the videos etc. here. But it can be a part of a different PR later in future.
  4. We should also mention about the template. Possibly in the development -> development guide.
  5. The seperation of projects and SDK is not apparent.

@movchan74
Copy link
Contributor Author

  1. Can you also add https://github.com/mobiusml/aana_sdk/wiki/Cluster-Setup ( maybe move it out of wiki to docs ) and add a section on scaling up the SDK ?

    1. There are ways to monitor Ray cluster, and is not apparent. We should probably talk about it somewhere ( not in detail during this version )

    2. We should link the videos etc. here. But it can be a part of a different PR later in future.

    3. We should also mention about the template. Possibly in the development -> development guide.

    4. The seperation of projects and SDK is not apparent.

I already mentioned the template.

The seperation of projects and SDK is not apparent.

What do you mean and what do you want me to do about it?

@appoose
Copy link
Contributor

appoose commented Jul 12, 2024 via email

@movchan74
Copy link
Contributor Author

Let us first move existing projects out and then a subsection in getting started section to make it clear

On Fri 12. Jul 2024 at 12:06, Aleksandr Movchan @.> wrote: 1. Can you also add https://github.com/mobiusml/aana_sdk/wiki/Cluster-Setup ( maybe move it out of wiki to docs ) and add a section on scaling up the SDK ? 2. There are ways to monitor Ray cluster, and is not apparent. We should probably talk about it somewhere ( not in detail during this version ) 3. We should link the videos etc. here. But it can be a part of a different PR later in future. 4. We should also mention about the template. Possibly in the development -> development guide. 5. The seperation of projects and SDK is not apparent. I already mentioned the template. The seperation of projects and SDK is not apparent. What do you mean and what do you want me to do about it? — Reply to this email directly, view it on GitHub <#135 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJL5SMY6ILMDW2MT5HMY7DZL6TDNAVCNFSM6AAAAABKYSXXSGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRVGI2DSNRZGU . You are receiving this because your review was requested.Message ID: @.>

Let us first move existing projects out

I'm working on it but it will be a separate PR. Is there anything you want me to do about it in this PR?

@appoose
Copy link
Contributor

appoose commented Jul 12, 2024

This is good to go

@appoose appoose closed this Jul 12, 2024
Copy link
Contributor

@appoose appoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@movchan74 movchan74 reopened this Jul 12, 2024
@movchan74 movchan74 merged commit a6961e8 into main Jul 12, 2024
9 checks passed
@movchan74 movchan74 deleted the docs_index branch July 12, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants