Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct find_packages wildcard behaviour #25

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

bclavie
Copy link
Contributor

@bclavie bclavie commented Mar 19, 2024

Hi there!

A very minor PR to fix the wildcard behaviour in setup.py. find_packages is quite tricky with things like that. Its parsing expects Python package/subpackage/modules, not paths, so the current format makes it build an empty lib (just the root __init__.py as it tries to find packages called hqq/ rather than hqq.*.

This minor change fixes that and properly builds everything.

@bclavie
Copy link
Contributor Author

bclavie commented Mar 19, 2024

@mobicham
Screenshots of pip install hqq==0.1.6
Screenshot 2024-03-19 at 15 54 34

vs with the setup.py fix
Screenshot 2024-03-19 at 15 55 11

@mobicham
Copy link
Collaborator

Hi @bclavie , thanks for pointing that out, I have actually just uploaded the pypi package and was about to try it. It should work fine now with pip install hqq

@mobicham mobicham merged commit 2d276ae into mobiusml:master Mar 19, 2024
@bclavie
Copy link
Contributor Author

bclavie commented Mar 19, 2024

Very coincidental! I was actually trying to install from source earlier and noticed the issue, then realised you'd released it to pypi right as I was about to create the PR haha.

Thanks for merging so quickly!

@mobicham
Copy link
Collaborator

Thanks! master should be fine now as well, will update the release now.

@mobicham
Copy link
Collaborator

I noticed another bug: pip install hqq doesn't automatically build the CUDA package, it works fine with pip install git+https://github.com/mobiusml/hqq.git

@bclavie
Copy link
Contributor Author

bclavie commented Mar 19, 2024

Hey, just had a look, it's because the .cpp and .cu files aren't packaged as part of setup.py. I've shot another mini-PR here to add them #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants