Update npm.yml GitHub workflow

mobsuccess-devops · Feb 20, 2024 · b5841a6 · b5841a6
1 parent 571d188
commit b5841a6
Showing 1 changed file with 48 additions and 19 deletions.
diff --git a/.github/workflows/npm.yml b/.github/workflows/npm.yml
@@ -3,6 +3,9 @@
 # If changes are needed, update the action npm in
 # https://github.com/mobsuccess-devops/github-mobsuccess-policy
 on:
+  merge_group:
+    types:
+      - checks_requested
   push:
     branches: [master, preprod, prod]
   pull_request:
@@ -14,28 +17,54 @@ jobs:
     runs-on: ubuntu-20.04
     timeout-minutes: 1
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - uses: mobsuccess-devops/github-actions-packagejsonlint@master
+  sortpackagejson:
+    name: Sort Package Json
+    runs-on: ubuntu-20.04
+    timeout-minutes: 7
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 16.16.0
+      - name: Cache Node Modules
+        id: cache
+        uses: actions/cache@v3
+        env:
+          cache-name: cache-node-modules
+        with:
+          path: ./node_modules
+          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/package-lock.json') }}-node-16.16.0
+      - run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.MS_READ_PACKAGES_GITHUB_PAT }}" >> ~/.npmrc
+        name: Configure Credentials For GitHub Packages
+      - run: npm ci
+        if: steps.cache.outputs.cache-hit != 'true'
+        working-directory: .
+      - run: |
+          echo "💡 👉 Check not passing? see the doc at https://www.notion.so/mobsuccess/sort-package-json-de5cf4648e8545dbb5a2a5a910380535"
+          npx --yes sort-package-json@2.4.1 --check
+        working-directory: .
   prettier:
     name: Prettier
     runs-on: ubuntu-20.04
     timeout-minutes: 7
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v3
         with:
-          node-version: ^16.13
+          node-version: 16.16.0
       - name: Cache Node Modules
         id: cache
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         env:
           cache-name: cache-node-modules
         with:
           path: ./node_modules
-          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
+          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/package-lock.json') }}-node-16.16.0
       - run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.MS_READ_PACKAGES_GITHUB_PAT }}" >> ~/.npmrc
         name: Configure Credentials For GitHub Packages
-      - run: npm install
+      - run: npm ci
         if: steps.cache.outputs.cache-hit != 'true'
         working-directory: .
       - run: npm run prettier
@@ -45,21 +74,21 @@ jobs:
     runs-on: ubuntu-20.04
     timeout-minutes: 7
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v3
         with:
-          node-version: ^16.13
+          node-version: 16.16.0
       - name: Cache Node Modules
         id: cache
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         env:
           cache-name: cache-node-modules
         with:
           path: ./node_modules
-          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
+          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/package-lock.json') }}-node-16.16.0
       - run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.MS_READ_PACKAGES_GITHUB_PAT }}" >> ~/.npmrc
         name: Configure Credentials For GitHub Packages
-      - run: npm install
+      - run: npm ci
         if: steps.cache.outputs.cache-hit != 'true'
         working-directory: .
       - run: npm run eslint
@@ -69,21 +98,21 @@ jobs:
     runs-on: ubuntu-20.04
     timeout-minutes: 7
     steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v3
         with:
-          node-version: ^16.13
+          node-version: 16.16.0
       - name: Cache Node Modules
         id: cache
-        uses: actions/cache@v2
+        uses: actions/cache@v3
         env:
           cache-name: cache-node-modules
         with:
           path: ./node_modules
-          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package-lock.json') }}
+          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/package.json') }}-${{ hashFiles('**/package-lock.json') }}-node-16.16.0
       - run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.MS_READ_PACKAGES_GITHUB_PAT }}" >> ~/.npmrc
         name: Configure Credentials For GitHub Packages
-      - run: npm install
+      - run: npm ci
         if: steps.cache.outputs.cache-hit != 'true'
         working-directory: .
       - run: npm run test