Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-scripts to 5.0.0 #280

Merged
merged 3 commits into from
Dec 23, 2021
Merged

Bump react-scripts to 5.0.0 #280

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d189284
Bump react-scripts from 4.0.3 to 5.0.0
dependabot[bot] Dec 20, 2021
5592968
fix eslint warning
pankona Dec 21, 2021
3f84ea0
Merge remote-tracking branch 'origin/main' into bump-react-scripts-5.0.0
pankona Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"js-cookie": "^3.0.1",
"react": "^17.0.2",
"react-dom": "^17.0.2",
"react-scripts": "^4.0.1",
"react-scripts": "^5.0.0",
"ress": "^4.0.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion src/pages/AppContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ const numberToTimeString = (count: number): string => {
return elapsedTime.toISOString().substr(11, 8);
};

const shuffleArray = <T extends unknown>(array: T[]): T[] => {
const shuffleArray = <T,>(array: T[]): T[] => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

for (let i = array.length - 1; i > 0; i--) {
const rand = Math.floor(Math.random() * (i + 1));
[array[i], array[rand]] = [array[rand], array[i]];
Expand Down
Loading