Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/chromedriver and playground setup #115

Conversation

coolsoftwaretyler
Copy link
Collaborator

Hey folks,

I'm poking around to see if I can help with #55.

Here's some cleanup I had to do to get started.

  1. Bumped chromedriver way up to latest version
  2. Not really sure what node version makes sense here, but 18 is still reasonably old and I think the only main compatibility changes we need are the openss-legacy-provider setting
  3. Updated the HACKING doc because it was using yarn, but this project has package-lock.json and a lot of the scripts are written with npm run
  4. Bumped .nvmrc to the v18 I was using.

This was enough to get me to successfully install the dependencies and run the playground script, although I see tests are failing. I think the old setup has some deprecated settings that we'll need to untangle before we can do much here.

@coolsoftwaretyler coolsoftwaretyler merged commit 08df9b1 into mobxjs:master Sep 18, 2024
@coolsoftwaretyler coolsoftwaretyler deleted the fix/chromedriver-and-playground-setup branch September 18, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants