Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove --legacy-peer-deps flag and downgrade dependencies for … #122

Conversation

grvv
Copy link
Contributor

@grvv grvv commented Oct 15, 2024

remove --legacy-peer-deps flag and downgrade dependencies

@coolsoftwaretyler
Copy link
Collaborator

Taking a look now, thank you!

@coolsoftwaretyler
Copy link
Collaborator

Love it, confirmed all scripts work (except for the FIrefox E2E tests, which have been broken for a while, not a blocker).

@coolsoftwaretyler coolsoftwaretyler merged commit 624b208 into mobxjs:master Oct 15, 2024
@grvv grvv deleted the remove-legacy-peer-deps-downgrade-dependencies branch October 15, 2024 19:39
@grvdisco
Copy link

More details from conversations on other threads:

In this PR, we opted to downgrade eslint-loader and a few other dependencies in order to maintain compatibility with Webpack 3 for the time being, instead of proceeding with a full Webpack upgrade. This keeps the scope of this PR more focused and allows us to address the bundler upgrade at a later time.

Key changes:

  • Downgraded eslint-loader and related dependencies.
  • Removed the --legacy-peer-deps flag from the bootstrap script, as everything now installs correctly without it.
  • Ensured that all scripts (bootstrap, build, start) are working as expected, with some warnings still present.
  • All test cases are passing.

This approach helps us move forward with minimal disruption, while we plan for the Webpack upgrade in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants