Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Webpack 5, updated linting and libs #127

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

grvv
Copy link
Contributor

@grvv grvv commented Oct 23, 2024

Webpack Migration

  • Migrated from Webpack v3 to v5, leveraging previous work from the v3 to v4 upgrade.
  • Updated all Webpack configurations to be compatible with Webpack 5.
  • Removed deprecated plugins and loaders, utilizing Webpack 5's built-in features.

Dependency Updates

  • Updated Babel libraries and adjusted .babelrc configurations.
  • Updated testing libraries, including Mocha and Chai.
  • Fixed linting issues by updating ESLint configurations (.eslintrc).
  • Ran Prettier on the codebase (npx prettier --write .) to ensure consistent code formatting.

Future Enhancements

  • Plan to experiment with Rspack for potential build performance improvements.

…plied Prettier for consistent formatting. Prepared for future tooling.
@grvv grvv changed the title Migrate to Webpack 5, update Babel, ESLint, and testing libraries. Ap… Migrate to Webpack 5, updated linting and libs Oct 23, 2024
@grvv
Copy link
Contributor Author

grvv commented Oct 23, 2024

Used the code from my previous PR to transition from Webpack v3 to v4 (#121).

@coolsoftwaretyler
Copy link
Collaborator

Thanks @grvv! Just got back from a work trip so I'll take a look this weekend but I suspect we'll get things merged pretty soon here.

@coolsoftwaretyler
Copy link
Collaborator

Looking good! There was an issue with the Electron playground with command npm run start-playground-electron, so I've fixed that in 3f59609. Will check the other commands one more time here.

@coolsoftwaretyler
Copy link
Collaborator

Everything except e2e tests is passing, and I've checked the built browser extension works in the playground. We've had problems with e2e tests for a while, so I will not block on that. Merging.

Thanks so much, @grvv!

@coolsoftwaretyler coolsoftwaretyler merged commit 3a0c831 into mobxjs:master Oct 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants