Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

why published package does not have minified version? #147

Closed
marty-wang opened this issue Nov 2, 2016 · 5 comments
Closed

why published package does not have minified version? #147

marty-wang opened this issue Nov 2, 2016 · 5 comments

Comments

@marty-wang
Copy link

npm module as well as CDN only have non-minified code. Why no minified version?

@mweststrate
Copy link
Member

The majority of React projects bundle using webpack. Minifying after bundling your complete project usually gives a better developer experience.

@marty-wang
Copy link
Author

I was hoping to use CDN for external libs, instead of bundling them with my app. but regardless, why not just minify it, and leave the developer to decide how to use it? I assume minification should be quite trivial.

@mweststrate
Copy link
Member

@marty-wang I have no problem with adding that, it's just that so far nobody needed it. Seems CDN's are mostly interesting for PoCs and demo's, and less used for production apps.

Feel free to create a PR, or leave this issue open so that somebody else will pick it up :) Which flavors would be interesting for you, I assume only the default HTML renderer is interesting?

@marty-wang
Copy link
Author

yes. only html renderer should be fine. Thanks.

@mweststrate mweststrate mentioned this issue Nov 7, 2016
13 tasks
@mweststrate
Copy link
Member

This change can be tested with mobx-react@4.0.0-rc.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants