This repository has been archived by the owner on Dec 31, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to avoid double render on props/state modifications.
Prevents infinite recursion.
This helps prevent double-render of component.
React's default behaviour is to re-render component if setState called, even if called without actually state modifiication. This adds test case, that `observer` decorator don't break this behaviour.
@mweststrate as discussed at #136, I've added test case for |
@Strate tnx!
|
See: discussion 666577b
Encountered reaction loops when testing rc.1 against our test suite. Will investigate further |
@mweststrate great work! Could you please publish 4.0.0-rc.2 (or I can do it) |
@mweststrate what exactly included from #160? I don't see any commit... |
Dôh, forgot to tag the commit: https://github.com/mobxjs/mobx-react/compare/v4...160-pure-observer?expand=1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open items
inject
a reactive function as well #111 (inject should be reactive)?Observer
as higher order component #138,Observer
regionsobserver
always apply pure? #160, always pureobserver
React.batchedUpdates
, even outside react events