Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

WIP: V4 #154

Merged
merged 51 commits into from
Nov 21, 2016
Merged

WIP: V4 #154

merged 51 commits into from
Nov 21, 2016

Conversation

mweststrate
Copy link
Member

@mweststrate mweststrate commented Nov 7, 2016

Open items

Andrey Kogut and others added 6 commits November 7, 2016 22:06
React's default behaviour is to re-render component if setState called, even if called without actually state modifiication.

This adds test case, that `observer` decorator don't break this behaviour.
@Strate
Copy link
Contributor

Strate commented Nov 8, 2016

@mweststrate as discussed at #136, I've added test case for setState() -> reRender case.

@mweststrate
Copy link
Member Author

@Strate tnx!

mobx-react@4.0.0-beta.1 is now available on NPM

@mweststrate
Copy link
Member Author

Encountered reaction loops when testing rc.1 against our test suite. Will investigate further

@Strate
Copy link
Contributor

Strate commented Nov 15, 2016

@mweststrate great work! Could you please publish 4.0.0-rc.2 (or I can do it)

@mweststrate
Copy link
Member Author

@Strate just did that a few minutes ago :-D. It also includes #160 btw mobx-react@4.0.0-rc.2

@Strate
Copy link
Contributor

Strate commented Nov 15, 2016

@mweststrate what exactly included from #160? I don't see any commit...

@mweststrate
Copy link
Member Author

@mweststrate mweststrate merged commit 67d42bb into master Nov 21, 2016
@mweststrate mweststrate deleted the v4 branch March 30, 2017 13:58
@mweststrate mweststrate restored the v4 branch March 30, 2017 13:59
@mweststrate mweststrate deleted the v4 branch March 30, 2017 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants