Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

RN: unable to resolve react-dom on 4.0.0-rc3 #162

Closed
vonovak opened this issue Nov 18, 2016 · 4 comments
Closed

RN: unable to resolve react-dom on 4.0.0-rc3 #162

vonovak opened this issue Nov 18, 2016 · 4 comments

Comments

@vonovak
Copy link
Contributor

vonovak commented Nov 18, 2016

No description provided.

@mweststrate
Copy link
Member

are you requiring from mobx-react/native ?

Op vr 18 nov. 2016 13:26 schreef Vojtech Novak notifications@github.com:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#162, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvGhN_hRBthbcEsu-nByni3LhnuPxcPks5q_ZldgaJpZM4K2beB
.

@vonovak
Copy link
Contributor Author

vonovak commented Nov 18, 2016

Yes, I am. I did npm i of mobx-react rc3 and got this error. I looked at the native.js file and saw "react-dom" directly in there, around line 140 if i remember correctly.

@mweststrate
Copy link
Member

@vonovak ok thanks for reporting, I'll investigate it! It should be stubbed :(

mobx-react/webpack.config.js

Line 26 in 83e7e93

'react-dom': 'empty-module',

@mweststrate mweststrate mentioned this issue Nov 18, 2016
Merged
13 tasks
@mweststrate
Copy link
Member

Could you try 4.0.0-rc.4?

@vonovak vonovak closed this as completed Nov 21, 2016
mweststrate added a commit that referenced this issue Nov 21, 2016
@mweststrate
Fixed packaging issue, see #162
67d42bb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vonovak @mweststrate