Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

Issue #155 - ES6 Test support #158

Merged
merged 4 commits into from
Nov 14, 2016
Merged

Issue #155 - ES6 Test support #158

merged 4 commits into from
Nov 14, 2016

Conversation

A-gambit
Copy link
Member

@A-gambit A-gambit commented Nov 11, 2016

Solve issue #155:

Add support of es6 and react to tests and refactor them.
Also add ability to build tests bundle and run it in browser: npm run test:build

@mweststrate please review

The next step to rewrite jquery to enzyme from some tests file.

@A-gambit A-gambit changed the title Issue [#155](https://github.com/mobxjs/mobx-react/issues/155) Issue #155 - ES6 Test support Nov 11, 2016
@A-gambit
Copy link
Member Author

@mweststrate there is no js linter in this repository. Is it ok? I can add eslint, in my next pull.

@andykog
Copy link
Member

andykog commented Nov 12, 2016

Vote for eslint-config-airbnb!

@A-gambit
Copy link
Member Author

A-gambit commented Nov 12, 2016

@andykog @mweststrate Yep! I think about it.
Also, it will be better to add eslint to MobX and MobX-Utils, too.

@mweststrate
Copy link
Member

Looking great so far @A-gambit! and +1 for linting :)

@A-gambit
Copy link
Member Author

@mweststrate Can I merge it in v4?

@A-gambit
Copy link
Member Author

@andykog @mweststrate What do you think about semicoma rule? Do we need it? In my opinion, it is important in typescript files, but what about javascript? I have already start lint feature in mobx-utils.

@andykog
Copy link
Member

andykog commented Nov 13, 2016

I, personally, hate missing semicolons in JS :-)

@mweststrate
Copy link
Member

@A-gambit yes feel free to merge.
Personally, I prefer no semicolons (even in typescript) but I can live with both. same for tabs or spaces. But I have a strong preference for width = 4 ;-)

@A-gambit A-gambit merged commit 927b575 into v4 Nov 14, 2016
@A-gambit A-gambit deleted the es6-unit-tests branch November 14, 2016 08:41
@A-gambit
Copy link
Member Author

@mweststrate @andykog I will create a pull in mobx-util soon and we will discuss code style there)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants