Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

Use circleci instead of travis for ci and add size-limit #675

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

pustovalov
Copy link
Contributor

Size Limit is a linter for your JS application or library performance. It calculates the real cost of your JS for end users and throws an error if the cost exceeds the limit.

https://github.com/ai/size-limit

Example:

yarn run v1.15.2
$ size-limit

  Size limit:   10 KB
  Package size: 7.19 KB minified and gzipped
  Loading time: 144 ms  on slow 3G

Done in 0.80s.

Example of circle ci build: https://circleci.com/workflow-run/e32e556e-12f7-47af-865b-8043cf544224

@pustovalov pustovalov changed the title Use circleci instead of travis for ci && add size-limit Use circleci instead of travis for ci and add size-limit May 19, 2019
@mweststrate
Copy link
Member

@pustovalov would you remind rebasing this PR?

@pustovalov pustovalov force-pushed the pp-circle-limit branch 2 times, most recently from 61259ba to c00896e Compare June 4, 2019 21:16
@pustovalov
Copy link
Contributor Author

@danielkcz
Copy link
Contributor

danielkcz commented Jun 8, 2019

@pustovalov I am not familiar with CircleCI. That example link needs a login apparently. Does it have the option to see output publically? It's not viable asking every contributor to sign in with the service to see why are tests failing.

@danielkcz
Copy link
Contributor

I do wonder though, why CircleCI? Using size-limit is fine, but why to switch to CC? Does it bring any advantage? Plenty of OSS contributors are used to Travis UI. Using something else makes it only harder.

@pustovalov
Copy link
Contributor Author

@FredyC sry, previous link was private. You can see a result of tests here: https://circleci.com/gh/pustovalov/mobx-react

I think CircleCI more flexible than Travis, and https://github.com/mobxjs/mobx-state-tree also uses CircleCI

@danielkcz
Copy link
Contributor

@xaviergonz Can you please review this since you originally configured CC for mobx-state-tree?

Copy link
Contributor

@xaviergonz xaviergonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@danielkcz danielkcz merged commit 4904b62 into mobxjs:master Jun 10, 2019
@pustovalov
Copy link
Contributor Author

@FredyC @xaviergonz need to turn on mobx-react repo on circle and add COVERALLS_REPO_TOKEN to environment variables

@danielkcz
Copy link
Contributor

@xaviergonz I don't seem to have access to that, can you do it, please?

@xaviergonz
Copy link
Contributor

Sure, I'll do it in some hours once I get home

@xaviergonz
Copy link
Contributor

done: https://circleci.com/gh/mobxjs/mobx-react

@xaviergonz
Copy link
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants