-
-
Notifications
You must be signed in to change notification settings - Fork 350
Use circleci instead of travis for ci and add size-limit #675
Conversation
257464e
to
063b557
Compare
@pustovalov would you remind rebasing this PR? |
61259ba
to
c00896e
Compare
c00896e
to
02c41e9
Compare
@mweststrate I have fixed the conflicts CI build: https://circleci.com/workflow-run/f3742ca7-a2e9-48aa-bd01-53ee1a31e8b0 |
@pustovalov I am not familiar with CircleCI. That example link needs a login apparently. Does it have the option to see output publically? It's not viable asking every contributor to sign in with the service to see why are tests failing. |
I do wonder though, why CircleCI? Using size-limit is fine, but why to switch to CC? Does it bring any advantage? Plenty of OSS contributors are used to Travis UI. Using something else makes it only harder. |
@FredyC sry, previous link was private. You can see a result of tests here: https://circleci.com/gh/pustovalov/mobx-react I think CircleCI more flexible than Travis, and https://github.com/mobxjs/mobx-state-tree also uses CircleCI |
@xaviergonz Can you please review this since you originally configured CC for mobx-state-tree? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@FredyC @xaviergonz need to turn on |
@xaviergonz I don't seem to have access to that, can you do it, please? |
Sure, I'll do it in some hours once I get home |
Size Limit is a linter for your JS application or library performance. It calculates the real cost of your JS for end users and throws an error if the cost exceeds the limit.
https://github.com/ai/size-limit
Example:
Example of circle ci build: https://circleci.com/workflow-run/e32e556e-12f7-47af-865b-8043cf544224