Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type system improvements, fixes #66 #67

Merged
merged 3 commits into from
Apr 3, 2017
Merged

Type system improvements, fixes #66 #67

merged 3 commits into from
Apr 3, 2017

Conversation

mweststrate
Copy link
Member

This PR ensures a few things:

  • Correct primitive type is inferred from the default value
  • If a default value is present, it can be omitted in snapshots
  • null and undefined are not acceptable as model attributes (should specify maybe)
  • Superfluous attributes in snapshots are ignored (see Additional fields #66)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 92.093% when pulling b58d6b2 on type-system-improvements into b9f1698 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 92.093% when pulling b58d6b2 on type-system-improvements into b9f1698 on master.

@mweststrate
Copy link
Member Author

Merged, feel free to leave comments nonetheless

@mweststrate mweststrate merged commit 26c305b into master Apr 3, 2017
@mattiamanzati mattiamanzati deleted the type-system-improvements branch May 8, 2017 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattiamanzati mattiamanzati Awaiting requested review from mattiamanzati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mweststrate @coveralls