Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add & apply yarn deduplicate #2078

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Conversation

Bnaya
Copy link
Member

@Bnaya Bnaya commented Aug 16, 2019

Motivation:
yarn is actually missing automatic dedup of deps,
Which leads to multiple-but-compatible versions of deps.
yarn-deduplicate is a complementary tool to solve that.

It's recommended to run it after any dependencies add/remove/upgrade

Related:
yarnpkg/yarn#3778
(And there are more issues around yarn repo related to that)

Motivation:
yarn is actually missing automatic dedup of deps,
Which leads to multiple-but-compatible versions of deps.

It's recommended to run it after any dependencies add/remove/upgrade

Related:
yarnpkg/yarn#3778
(And there are more issues around yarn repo related to that)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.275% when pulling 52ef3b3 on apply-yarn-deduplicate into a3ec6b1 on master.

@mweststrate mweststrate merged commit 0c4b0a0 into master Aug 16, 2019
@mweststrate
Copy link
Member

Thanks! Interesting tool, not sure we really needed, but if it works without prob, might make it slightly faster for people to contribute

@Bnaya Bnaya deleted the apply-yarn-deduplicate branch August 16, 2019 21:08
@Bnaya
Copy link
Member Author

Bnaya commented Aug 16, 2019

The yarn.lock got little bit smaller,
means the node_modules was little bit bigger and nested than it could be.
in some repos deduping cleaning up maybe third of the lock file.

@danielkcz
Copy link
Contributor

Wouldn't it be better to just npx yarn-deduplicate? Adding it to deps it's not exactly sure what it has done because some other deps got in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants