Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: observable use internal constants #2902

Merged
merged 3 commits into from
Jun 21, 2021
Merged

chore: observable use internal constants #2902

merged 3 commits into from
Jun 21, 2021

Conversation

rogerleung0411
Copy link
Contributor

@rogerleung0411 rogerleung0411 commented Apr 19, 2021

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (npm run perf)

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2021

🦋 Changeset detected

Latest commit: 92224a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iChenLei iChenLei requested a review from mweststrate April 20, 2021 11:00
Copy link
Member

@iChenLei iChenLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urugator
Copy link
Collaborator

I think these constants aren't use anywhere else and can be deleted.
Same for FLOW, COMPUTED_STRUCT, ACTION_BOUND, AUTOACTION_BOUND, AUTO.
ACTION, AUTOACTION, COMPUTED can be made private (without export)

@urugator urugator merged commit d78a159 into mobxjs:main Jun 21, 2021
@urugator
Copy link
Collaborator

Left as is for the sake of consistency

@github-actions github-actions bot mentioned this pull request Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants