Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: spy: bound actions report correct object #3141

Merged
merged 7 commits into from
Oct 11, 2021

Conversation

urugator
Copy link
Collaborator

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2021

🦋 Changeset detected

Latest commit: 039182e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@urugator urugator changed the title Fix: bound actions report correct object Fix: spy: bound actions report correct object Oct 11, 2021
Copy link
Member

@mweststrate mweststrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@urugator urugator merged commit 0dbf3eb into mobxjs:main Oct 11, 2021
@github-actions github-actions bot mentioned this pull request Oct 11, 2021
@kubk
Copy link
Collaborator

kubk commented Oct 12, 2021

@urugator Sorry for bothering. When do you plan to publish it? The package version in NPM is still 6.3.3: https://www.npmjs.com/package/mobx

While in GitHub it's already 6.3.4: https://github.com/mobxjs/mobx/releases/tag/mobx%406.3.4

@urugator
Copy link
Collaborator Author

I am quite unfamiliar with publishing (I've never done it manually and I don't even know if I have permissions).
No errors in actions log 😕:
🦋 info Publishing "mobx" at "6.3.4"
🦋 info Publishing "mobx-react" at "7.2.1"
🦋 success packages published successfully:
🦋 mobx@6.3.4
🦋 mobx-react@7.2.1

@kubk
Copy link
Collaborator

kubk commented Oct 13, 2021

@urugator Thank you. I still see the 6.3.3 in NPM: https://www.npmjs.com/package/mobx

The command npm i mobx@latest also installs 6.3.3

Maybe @FredyC or @mweststrate could help publishing the new version?

@iChenLei
Copy link
Member

Search mobx, show latest version is v6.3.4

2021-10-13 20 34 53

But in home page, the latest version is v6.3.3

https://www.npmjs.com/package/mobx

Maybe it's npm self error ?

@mweststrate
Copy link
Member

Looks like a bit fell over at NPM. Seems 6.3.5 did get published correctly again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants