Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: update dependencies (including runc rc10) #1343

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Dockerfile: update dependencies (including runc rc10) #1343

merged 1 commit into from
Jan 28, 2020

Conversation

AkihiroSuda
Copy link
Member

@tonistiigi : Please update Docker Hub tonistiigi images?

@AkihiroSuda AkihiroSuda force-pushed the dockerfile-runc-rc10 branch 2 times, most recently from ef7b8cb to 7aafaeb Compare January 24, 2020 07:29
@AkihiroSuda
Copy link
Member Author

If we can trust qemu-user to be matured enough to run apk, we no longer need tonistiigi/buildkit:rootless-base?

@tonistiigi
Copy link
Member

@AkihiroSuda Yes. Possibly we can switch some workflows to buildx as well.

@AkihiroSuda
Copy link
Member Author

Can we remove tonistiigi/buildkit:rootless-base in this PR? Or is it safer to do that in a separate PR?

tonistiigi
tonistiigi reviewed Jan 24, 2020
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
tonistiigi
tonistiigi reviewed Jan 24, 2020
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@tonistiigi
Copy link
Member

@AkihiroSuda Better to keep it at least separate commits. That will mostly be travis change I believe.

@AkihiroSuda AkihiroSuda force-pushed the dockerfile-runc-rc10 branch 2 times, most recently from dbd9b11 to f9a8f6e Compare January 24, 2020 19:25
@AkihiroSuda
Dockerfile: update dependencies (including runc rc10)
b7e189d 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Member Author

updated

@tonistiigi tonistiigi merged commit 3790395 into moby:master Jan 28, 2020
@tonistiigi
Copy link
Member

@AkihiroSuda Do you want to make a PR to update to qemu or do I manually push new versions these base images?

@AkihiroSuda
Copy link
Member Author

Could you push manually new versions first, and then we can try to update to qemu in a separate PR?

@tonistiigi
Copy link
Member

Don't think we should pick this to v0.6 . v0.6 is still containerd 1.2

@AkihiroSuda
Copy link
Member Author

runc needs update, no?

@tonistiigi
Copy link
Member

@AkihiroSuda is it critical? If you think it is make another pr straight to 19.03 branch. btw, https://github.com/docker/engine/blob/19.03/hack/dockerfile/install/runc.installer seems to have rc9 atm

@tonistiigi tonistiigi mentioned this pull request Feb 13, 2020
Merged
@AkihiroSuda AkihiroSuda mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AkihiroSuda @tonistiigi