progressui: modify NewDisplay to accept io.Writer instead of console.File #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
io-writer-display
branch
from
bb35e4d to
8361700
Compare
tonistiigi
approved these changes
Sep 11, 2023
|
@jsternberg Forgot DCO |
jsternberg
force-pushed
the
io-writer-display
branch
from
8361700 to
2cc12c9
Compare
…File The original intention of accepting `console.File` was that the current uses of this function in the codebase were always files and it seemed helpful to restrict the API to `console.File` to aid developers into passing the correct output. There are circumstances outside of the codebase where the `io.Writer` versions are used so `NewDisplay` has now been adapted to take an `io.Writer` to allow for those cases more easily. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
io-writer-display
branch
from
2cc12c9 to
f53bc88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intention of accepting
console.Filewas that the currentuses of this function in the codebase were always files and it seemed
helpful to restrict the API to
console.Fileto aid developers intopassing the correct output.
There are circumstances outside of the codebase where the
io.Writerversions are used so
NewDisplayhas now been adapted to take anio.Writerto allow for those cases more easily.Related to #4113 (comment).