Include OS version and features in OCI platforms #4387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBBle
commented
Oct 27, 2023
|
Thanks for the fix! |
profnandaa
reviewed
Oct 30, 2023
tonistiigi
reviewed
Nov 1, 2023
TBBle
force-pushed
the
include-OS-version-and-features-in-platforms
branch
2 times, most recently
from
20f2fe1
to
ca6d8c5
Compare
TBBle
commented
Nov 2, 2023
Trivially created by looking for every reference to .Variant and adding OSVersion and OSFeatures, except the ones related to the string representation of a Platform instance. I then went through and ensured every assignment of OSFeatures that might leak out, i.e., not local-only or for marhsalling purposes, uses the append-to-nil idiom to avoid sharing the slice storage and allowing accidental mutation after-the-fact. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
TBBle
force-pushed
the
include-OS-version-and-features-in-platforms
branch
from
ca6d8c5
to
98e0d8d
Compare
|
|
tonistiigi
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of places where these OCI fields were being stripped or lost during processing.
It hasn't been visible until now as they are
nilon all Linux platforms as far as I know, but WCOW needs them to select the appropriate image forFROMfrom a manifest list, and also probably in other places that I haven't tested.Draft because of one TODO to be completed/improved, and because I suspect this will warrant discussion. I'd also like to see if CI passes, in case I'm wrong about this not affecting Linux at all, e.g., unexpected digest shifts.