add an option to show JSON cache metrics #4464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Ah, from the initial issue I thought you meant something on the daemon side. I think this is fine though, maybe "debug" prefix for the buildctl flag? @AkihiroSuda wdyt?
👍 |
|
Owkay, switching for |
azr
force-pushed
the
azr/cache-metrics
branch
3 times, most recently
from
34836ad
to
71f1a05
Compare
Signed-off-by: Adrien Delorme <azr@users.noreply.github.com>
Signed-off-by: Adrien Delorme <azr@users.noreply.github.com>
azr
force-pushed
the
azr/cache-metrics
branch
from
15debcd
to
4494bf6
Compare
tonistiigi
approved these changes
Dec 14, 2023
|
Thanks for the green checkmark ! Is there anything I can do from here ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
this adds a new
json-cache-metricsparameter to write to anos.File. Handy in deamonless mode, mode with which it is a bit hard to scrape metrics the good way.At first it was just writting to stderr like the rest, after everything is done. But while seeking the end of log file to just get the last line works, it turned out a bit brittle at scale (in our case).
So I made it possible to pick a file just like for
trace. (But also kept the std(out/err) option, nice locally)LMK what you think.
Closes #4445