Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set codecov token #4660

Merged
merged 1 commit into from
Feb 19, 2024
Merged

ci: set codecov token #4660

merged 1 commit into from
Feb 19, 2024

Conversation

crazy-max
Copy link
Member

related to https://github.com/moby/buildkit/actions/runs/7957965041/job/21723057849#step:9:41

image

Since https://github.com/codecov/codecov-action/releases/tag/v4.0.0, the token is now required for public repos when the action runs on a branch/tag of this repo. But contributors creating PRs from their forks to the upstream repo will be able to get coverage information from Codecov. I guess this is because they don't have access to the secret. This is related to https://about.codecov.io/blog/january-product-update-updating-the-codecov-ci-uploaders-to-the-codecov-cli/

As discussed with @thaJeztah, an org-wide secret has been created so it can be used across repos of this org to fix this issue.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (but perhaps a note would be useful, or would it be clear for readers?)

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants