-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add quick guide for windows #4692
Conversation
|
6346f40
to
b6deb56
Compare
docs/windows.md
Outdated
### Platform requirements | ||
|
||
- Architecture: `amd64`, `arm64` (binaries available but not officially tested yet). | ||
- Supported OS: Windows Server 2022, Windows 11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably have this as a table indicating OS Versions and Supported Container OS across each version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Linking the main compatibility matrix table from MS docs - https://learn.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/version-compatibility?tabs=windows-server-2019%2Cwindows-11#windows-server-host-os-compatibility
PTAL CI error as well |
b6deb56
to
ea8442b
Compare
@crazy-max -- somehow I missed your comments when looking at the diff. Addressing them in a few. |
ea8442b
to
3c1fa35
Compare
Not sure what I'm missing for my |
3c1fa35
to
1ebd0be
Compare
There was an extra new line after https://github.com/moby/buildkit/blob/master/README.md?plain=1#L46 Should be good now. |
1ebd0be
to
ebc02ff
Compare
This commit adds a quick guide for setting up Buildkit on Windows, now that we currently have an experimental support. Additionally, this excludes `*.exe` files from being tracked by Git, especially those outside the `/bin` directory like the ones produced by the debugger. Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
ebc02ff
to
e478394
Compare
This commit adds a quick guide for setting up Buildkit on Windows, now that we currently have an experimental support.