Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add quick guide for windows #4692

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

profnandaa
Copy link
Collaborator

@profnandaa profnandaa commented Feb 26, 2024

This commit adds a quick guide for setting up Buildkit on Windows, now that we currently have an experimental support.

@profnandaa
Copy link
Collaborator Author

profnandaa commented Feb 26, 2024

PS. will fix the TOC issue... fixed

@profnandaa profnandaa force-pushed the docs/windows-quick-guide branch 2 times, most recently from 6346f40 to b6deb56 Compare February 26, 2024 14:39
docs/windows.md Outdated
### Platform requirements

- Architecture: `amd64`, `arm64` (binaries available but not officially tested yet).
- Supported OS: Windows Server 2022, Windows 11.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have this as a table indicating OS Versions and Supported Container OS across each version

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonistiigi tonistiigi added this to the v0.13.0 milestone Feb 26, 2024
README.md Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
docs/windows.md Show resolved Hide resolved
@tonistiigi
Copy link
Member

PTAL CI error as well

README.md Outdated Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@profnandaa
Copy link
Collaborator Author

@crazy-max -- somehow I missed your comments when looking at the diff. Addressing them in a few.

@profnandaa
Copy link
Collaborator Author

PTAL CI error as well

Not sure what I'm missing for my doctoc validation, was running successfully locally.

@crazy-max
Copy link
Member

PTAL CI error as well

Not sure what I'm missing for my doctoc validation, was running successfully locally.

There was an extra new line after https://github.com/moby/buildkit/blob/master/README.md?plain=1#L46

Should be good now.

.gitignore Outdated Show resolved Hide resolved
docs/windows.md Show resolved Hide resolved
docs/windows.md Outdated Show resolved Hide resolved
This commit adds a quick guide for setting up Buildkit on Windows,
now that we currently have an experimental support.

Additionally, this excludes `*.exe` files from being tracked by
Git, especially those outside the `/bin` directory like the ones
produced by the debugger.

Signed-off-by: Anthony Nandaa <profnandaa@gmail.com>
@tonistiigi tonistiigi merged commit 3888649 into moby:master Feb 28, 2024
14 checks passed
@profnandaa profnandaa deleted the docs/windows-quick-guide branch February 28, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants