Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lint subrequest to return build error #4891

Merged

Conversation

daghack
Copy link
Collaborator

@daghack daghack commented Apr 27, 2024

This PR updates the lint subrequest so that in the case of encountering a build error, it can return the lint warnings which occurred up to that point as well as the error message and source location where the error occurred.

It also updates tests, refactoring a bit to better accommodate for the increasing number of parameters to the checkLinterWarnings function.

@daghack daghack marked this pull request as draft April 27, 2024 02:26
@daghack daghack force-pushed the return-lint-warnings-after-build-err branch from d635c7e to 809f083 Compare April 27, 2024 02:31
@daghack daghack self-assigned this Apr 27, 2024
@daghack daghack force-pushed the return-lint-warnings-after-build-err branch 2 times, most recently from cc152a7 to ac9e7ca Compare April 29, 2024 15:13
@daghack daghack marked this pull request as ready for review April 29, 2024 15:13
@daghack daghack force-pushed the return-lint-warnings-after-build-err branch from ac9e7ca to 84d926e Compare April 29, 2024 22:30
… rather than a failed grpc response

Signed-off-by: Talon Bowler <talon.bowler@docker.com>
@daghack daghack force-pushed the return-lint-warnings-after-build-err branch from 84d926e to 438f30f Compare April 29, 2024 22:40
@tonistiigi tonistiigi merged commit dd6acb2 into moby:master Apr 29, 2024
73 checks passed
@daghack daghack deleted the return-lint-warnings-after-build-err branch April 30, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants