-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lint Controls #4962
Add Lint Controls #4962
Conversation
7df288f
to
75d1f1f
Compare
@@ -13,12 +13,14 @@ import ( | |||
|
|||
const ( | |||
keySyntax = "syntax" | |||
keyCheck = "check" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colinhemmings I'm not sure if "check" works in here.
#syntax=docker/dockerfile
#check=skip=StageNameCasing
FROM alpine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a comment on the proposal related that rule
would be a better term to use here
3ddfca2
to
4216f7c
Compare
7f1f006
to
86eb9be
Compare
3e4e01b
to
6f2e67d
Compare
30807ff
to
0a29cdf
Compare
@@ -162,6 +162,67 @@ func ListTargets(ctx context.Context, dt []byte) (*targets.List, error) { | |||
return l, nil | |||
} | |||
|
|||
func parseLintOptions(checkStr string) (*linter.Config, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future I think this can be moved to public function in linter pkg (and called both from here in dockerui) but that can be changed in some follow-up PR.
be11de7
to
593dc8e
Compare
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
Implements most of #4919 (the
check-skip
directive for skipping a specific is omitted as follow up work in a forthcoming PR)