dockerfile/parse: Fix nil dereference of a linter #4984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a nil dereference panic happening when parsing `ENV` and `LABEL` commands without a linter introduced by 6cfa459. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
tonistiigi
reviewed
Jun 3, 2024
| @@ -209,7 +209,7 @@ func parseKvps(args []string, cmdName string, location []parser.Range, lint *lin | |||
| return nil, errBlankCommandNames(cmdName) | |||
| } | |||
| name, value, sep := args[j], args[j+1], args[j+2] | |||
| if sep == "" { | |||
| if lint != nil && sep == "" { | |||
| msg := linter.RuleLegacyKeyValueFormat.Format(cmdName) | |||
| lint.Run(&linter.RuleLegacyKeyValueFormat, location, msg) | |||
There was a problem hiding this comment.
Maybe safer to do this check in the lint.Run() method, but that can be future follow-up.
There was a problem hiding this comment.
We should probably find a way to make it so calling linter methods is always valid. I think this is good to just take care of the current issue though.
jsternberg
approved these changes
Jun 3, 2024
| @@ -209,7 +209,7 @@ func parseKvps(args []string, cmdName string, location []parser.Range, lint *lin | |||
| return nil, errBlankCommandNames(cmdName) | |||
| } | |||
| name, value, sep := args[j], args[j+1], args[j+2] | |||
| if sep == "" { | |||
| if lint != nil && sep == "" { | |||
| msg := linter.RuleLegacyKeyValueFormat.Format(cmdName) | |||
| lint.Run(&linter.RuleLegacyKeyValueFormat, location, msg) | |||
There was a problem hiding this comment.
We should probably find a way to make it so calling linter methods is always valid. I think this is good to just take care of the current issue though.
vvoland
added a commit
to vvoland/moby
that referenced
this pull request
Jun 4, 2024
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
|
Replaced by #4996 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a nil dereference panic happening when parsing
ENVandLABELcommands without a linter introduced by 6cfa459.Signed-off-by: Paweł Gronowski pawel.gronowski@docker.com