grpcerrors: adapt grpcerrors to support more enriched error structures #5203
+1,036
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to finish the v1 compatibility tests. I also discovered a bug in typeurl while I was working on this and that's filed here: containerd/typeurl#47. |
jsternberg
force-pushed
the
grpc-errdefs
branch
from
3782c05
to
ab04318
Compare
jsternberg
force-pushed
the
grpc-errdefs
branch
2 times, most recently
from
f64f405
to
f91d4c7
Compare
stevvooe
reviewed
Aug 5, 2024
| // stack.Stack is affected by the same bug as the other | ||
| // typed errors so reuse that marshaling function to | ||
| // marshal the stack trace. | ||
| return marshalTypedError(st) | ||
| } | ||
|
|
||
| func Code(err error) codes.Code { |
There was a problem hiding this comment.
The code here looks good and favors the right error code but it might be good to define that in the docs.
jsternberg
force-pushed
the
grpc-errdefs
branch
from
f91d4c7
to
859c4ea
Compare
|
I tried to do this with just using the |
jsternberg
force-pushed
the
grpc-errdefs
branch
3 times, most recently
from
2731511
to
7fe8b20
Compare
The grpcerrors package has been updated to support more enriched error structures. The serialization structure has been changed to capture the original structure of the error and to serialize and deserialize into that same structure. Wrapped errors should be maintained with the same structure for unwrapping. `Unwrap() []error` is now supported so `errors.Join` and anything else that wraps multiple errors can now be used and are serialized/deserialized correctly. More methods of determining the grpc code are now supported and they will respect error wrapping. The errors in `github.com/containerd/errdefs` are now also used for mapping error codes with more likely to appear in the future. The marshaling will marshal both the new format and the old format in a way where a client that reads either will succeed. That makes this method compatible with old clients. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
grpc-errdefs
branch
from
7fe8b20
to
80dd115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grpcerrors package has been updated to support more enriched error structures.
The serialization structure has been changed to capture the original structure of the error and to serialize and deserialize into that same structure. Wrapped errors should be maintained with the same structure for unwrapping.
Unwrap() []erroris now supported soerrors.Joinand anything else that wraps multiple errors can now be used and are serialized/deserialized correctly.More methods of determining the grpc code are now supported and they will respect error wrapping. The errors in
github.com/containerd/errdefsare now also used for mapping error codes with more likely to appear in the future.The marshaling will marshal both the new format and the old format in a way where a client that reads either will succeed. That makes this method compatible with old clients.