feat: support lfs #5212
Open
feat: support lfs #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thxCode <thxcode0824@gmail.com>
crazy-max
reviewed
Aug 6, 2024
| @@ -539,6 +539,14 @@ func (gs *gitSourceHandler) Snapshot(ctx context.Context, g session.Group) (out | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| _, err = checkoutGit.Run(ctx, "lfs", "install", "--local") | |||
There was a problem hiding this comment.
I think we should check if lfs is supported (git >= 1.8.3.1): https://github.com/git-lfs/git-lfs/wiki/Installation#requirements
| @@ -539,6 +539,14 @@ func (gs *gitSourceHandler) Snapshot(ctx context.Context, g session.Group) (out | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| _, err = checkoutGit.Run(ctx, "lfs", "install", "--local") | |||
There was a problem hiding this comment.
Should we check if there are files being tracked by LFS first?
git lfs ls-files
Or maybe look for .gitattributes with filter=lfs like:
*.png filter=lfs diff=lfs merge=lfs -text
|
https://github.com/moby/buildkit/actions/runs/10241968157/job/28396722664?pr=5212#step:8:5671 |
I will try to address your comments, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the development of AI, more and more Git repositories use LFS to store model weights. The
ADDcommand already supports pulling from Git URLs, https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/reference.md#adding-files-from-a-url. This PR intends to support theADDcommand to pull content managed by Git LFS.