Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: frontend/dockerfile: update integration tests for windows/wcow (part 3) #5239

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

billywr
Copy link

@billywr billywr commented Aug 12, 2024

Updated tests in frontend/dockerfile/dockerfile_test.go to run on Windows.
Partially addressing #4485

  • testClientLLBProvenance
  • testNilProvenance
  • testDuplicatePlatformProvenance
  • testDockerIgnoreMissingProvenance
  • testCommandSourceMapping
  • testFrontendDeduplicateSources

@billywr billywr changed the title Add Windows container support in integration tests Add Windows container support in integration tests-part2 Aug 12, 2024
@billywr billywr force-pushed the wcow-integration-test-part2 branch from e30110a to 42d36fa Compare August 12, 2024 07:35
@billywr billywr changed the title Add Windows container support in integration tests-part2 tests: frontend/dockerfile: update integration tests for windows/WCOW-part2 Aug 12, 2024
@billywr billywr force-pushed the wcow-integration-test-part2 branch 4 times, most recently from b9ae506 to 0fa776e Compare August 14, 2024 13:18
Copy link
Collaborator

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than those few comments, lgtm.

frontend/dockerfile/dockerfile_provenance_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_provenance_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_provenance_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_provenance_test.go Outdated Show resolved Hide resolved
@billywr billywr force-pushed the wcow-integration-test-part2 branch from 0fa776e to b576990 Compare August 14, 2024 15:25
@billywr billywr changed the title tests: frontend/dockerfile: update integration tests for windows/WCOW-part2 tests: frontend/dockerfile: update integration tests for windows-part3 Aug 15, 2024
@billywr billywr changed the title tests: frontend/dockerfile: update integration tests for windows-part3 tests: frontend/dockerfile: update integration tests for windows/wcow(part 3) Aug 15, 2024
@billywr billywr force-pushed the wcow-integration-test-part2 branch 2 times, most recently from 5ce0854 to f76b8c2 Compare August 15, 2024 07:51
@billywr billywr changed the title tests: frontend/dockerfile: update integration tests for windows/wcow(part 3) tests: frontend/dockerfile: update integration tests for windows/wcow (part 3) Aug 15, 2024
@billywr billywr force-pushed the wcow-integration-test-part2 branch 12 times, most recently from 55e683f to 0923c5f Compare August 20, 2024 09:01
@billywr billywr force-pushed the wcow-integration-test-part2 branch 9 times, most recently from 7d919d5 to 19b7b6c Compare August 21, 2024 03:26
@billywr billywr marked this pull request as ready for review August 21, 2024 03:50
@billywr billywr force-pushed the wcow-integration-test-part2 branch 2 times, most recently from b088a88 to f182142 Compare August 23, 2024 09:16
… run on Windows.

Partially addressing moby#4485

Signed-off-by: Billy Owire <billyowire@microsoft.com>
@billywr billywr force-pushed the wcow-integration-test-part2 branch from f182142 to 99c771e Compare August 23, 2024 09:36
@crazy-max crazy-max merged commit 8c237af into moby:master Sep 2, 2024
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants