-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: frontend/dockerfile: update integration tests for windows/wcow (part 3) #5239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billywr
changed the title
Add Windows container support in integration tests
Add Windows container support in integration tests-part2
Aug 12, 2024
billywr
force-pushed
the
wcow-integration-test-part2
branch
from
August 12, 2024 07:35
e30110a
to
42d36fa
Compare
billywr
changed the title
Add Windows container support in integration tests-part2
tests: frontend/dockerfile: update integration tests for windows/WCOW-part2
Aug 12, 2024
billywr
force-pushed
the
wcow-integration-test-part2
branch
4 times, most recently
from
August 14, 2024 13:18
b9ae506
to
0fa776e
Compare
profnandaa
reviewed
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than those few comments, lgtm.
billywr
force-pushed
the
wcow-integration-test-part2
branch
from
August 14, 2024 15:25
0fa776e
to
b576990
Compare
billywr
changed the title
tests: frontend/dockerfile: update integration tests for windows/WCOW-part2
tests: frontend/dockerfile: update integration tests for windows-part3
Aug 15, 2024
billywr
changed the title
tests: frontend/dockerfile: update integration tests for windows-part3
tests: frontend/dockerfile: update integration tests for windows/wcow(part 3)
Aug 15, 2024
billywr
force-pushed
the
wcow-integration-test-part2
branch
2 times, most recently
from
August 15, 2024 07:51
5ce0854
to
f76b8c2
Compare
billywr
changed the title
tests: frontend/dockerfile: update integration tests for windows/wcow(part 3)
tests: frontend/dockerfile: update integration tests for windows/wcow (part 3)
Aug 15, 2024
profnandaa
reviewed
Aug 15, 2024
billywr
force-pushed
the
wcow-integration-test-part2
branch
12 times, most recently
from
August 20, 2024 09:01
55e683f
to
0923c5f
Compare
billywr
force-pushed
the
wcow-integration-test-part2
branch
9 times, most recently
from
August 21, 2024 03:26
7d919d5
to
19b7b6c
Compare
profnandaa
approved these changes
Aug 21, 2024
tonistiigi
reviewed
Aug 22, 2024
billywr
force-pushed
the
wcow-integration-test-part2
branch
2 times, most recently
from
August 23, 2024 09:16
b088a88
to
f182142
Compare
… run on Windows. Partially addressing moby#4485 Signed-off-by: Billy Owire <billyowire@microsoft.com>
billywr
force-pushed
the
wcow-integration-test-part2
branch
from
August 23, 2024 09:36
f182142
to
99c771e
Compare
tonistiigi
approved these changes
Aug 23, 2024
profnandaa
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated tests in
frontend/dockerfile/dockerfile_test.go
to run on Windows.Partially addressing #4485