Revendoring to move boltdb to bbolt #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Howard <jhoward@microsoft.com>
lowenna
changed the title
|
@thaJeztah PTAL :) |
tonistiigi
approved these changes
Sep 18, 2018
AkihiroSuda
approved these changes
Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Howard jhoward@microsoft.com
This PR does a bunch of revendoring to move from boltdb to bbolt, and to update to newer versions of other repos. The reason for that is there is a bug in the Windows boltdb, which is no longer maintained. The current maintained fork is in https://github.com/etcd-io/bbolt. The bug detail is in etcd-io/bbolt#121 and the fix is in etcd-io/bbolt#122. The fix is in release v1.3.1-etcd.8.
See moby/moby#37843 for a list of all components which are affected by this - the dependency chain is quite big, and this PR is the last big part to removing all references to boltdb across the "container" related repos, and ultimately being able to remove boltdb from moby/moby entirely.
This PR bumps containerd/containerd to a commit which doesn't use boltdb, but therefore also requires changes to containerd/go-runc.
While there, I noticed both Microsoft/hcsshim and Microsoft/go-winio are out of date, so bumped them to the latest releases. Same applied to opencontainers/runtime-spec.
I bumped libnetwork to 36d3bed0e9f4b3c8c66df9bd45278bb90b33e911 (version which uses bbolt), but that in turn requires adding ishidawataru/sctp @ 07191f837fedd2f13d1ec7b5f885f0f3ec54b1cb.