Do not hold the peer map lock during the peerDBNetworkWalk #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Boch <aboch@docker.com>
|
LGTM |
runcom
added a commit
to projectatomic/docker
that referenced
this pull request
Apr 27, 2017
Upstream reference: moby/libnetwork#1638 Upstream reference: moby#31016 BZ https://bugzilla.redhat.com/show_bug.cgi?id=1446184 Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom
added a commit
to projectatomic/docker
that referenced
this pull request
Apr 27, 2017
Upstream reference: moby/libnetwork#1638 Upstream reference: moby#31016 BZ https://bugzilla.redhat.com/show_bug.cgi?id=1446184 Signed-off-by: Antonio Murdaca <runcom@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it can lead to dead lock.
For example a dead lock on the channel send, if the walking function is
pushLocalEndpointEventwaiting on the event channel (size 1) to be drained, while the drainer functionserfLoopis blocked while processing an event which also locks on thenMap.Lock()itself.Signed-off-by: Alessandro Boch aboch@docker.com