Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore failure to save hns endpoint to store #1951

Merged
merged 1 commit into from
Oct 24, 2017
Merged

Ignore failure to save hns endpoint to store #1951

merged 1 commit into from
Oct 24, 2017

Conversation

msabansal
Copy link
Contributor

Workaround for #1950 to treat failure to save endpoint to store as non fatal. These endpoints are just required for cleanup in case of docker service crash and saving them is not really required and should not be considered fatal.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "savefail" git@github.com:msabansal/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Sandeep Bansal <sabansal@microsoft.com>
@codecov-io
Copy link

Codecov Report

Merging #1951 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1951      +/-   ##
==========================================
- Coverage      38%   37.99%   -0.01%     
==========================================
  Files         137      137              
  Lines       27149    27149              
==========================================
- Hits        10317    10315       -2     
- Misses      15562    15563       +1     
- Partials     1270     1271       +1
Impacted Files Coverage Δ
cmd/proxy/udp_proxy.go 60.82% <0%> (-9.28%) ⬇️
networkdb/cluster.go 46.73% <0%> (+0.61%) ⬆️
cmd/proxy/tcp_proxy.go 82.69% <0%> (+1.92%) ⬆️
endpoint_cnt.go 86.08% <0%> (+2.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c34e58a...6ea478c. Read the comment docs.

Copy link
Contributor

@mavenugo mavenugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mavenugo mavenugo merged commit 72fd7e5 into moby:master Oct 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants