Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.03 backport] Cleanup the cluster provider when the agent is closed #2353

Merged
merged 1 commit into from
Apr 15, 2019
Merged

[18.03 backport] Cleanup the cluster provider when the agent is closed #2353

merged 1 commit into from
Apr 15, 2019

Conversation

thaJeztah
Copy link
Member

backport of #2307 for the 18.03 branch

@kylewuolle @thaJeztah
Cleanup the cluster provider when the agent is closed
42972ca 
Signed-off-by: Kyle Wuolle <kyle.wuolle@gmail.com>
(cherry picked from commit c7125bd)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ping @mavenugo @euanh PTAL

@selansen
Copy link
Collaborator

selansen commented Apr 1, 2019

looks like TestNetworkDBIslands failing consistently ( Same failure on other backport too )

@thaJeztah
Copy link
Member Author 

--- FAIL: TestNetworkDBIslands (75.83s)
	Location:	networkdb_test.go:838
	Error:		"map[4ac5b1d46794:4ac5b1d46794 79fd1a707bd6:79fd1a707bd6]" should have 3 item(s), but has 2
		

	Location:	networkdb_test.go:839
	Error:		"map[2624cc77ef1d:2624cc77ef1d]" should have 0 item(s), but has 1
		

FAIL

Looks like it may be flaky #2240 (comment)

@thaJeztah
Copy link
Member Author

Don't have permissions to trigger CI in this repo 😕

@selansen
Copy link
Collaborator

selansen commented Apr 1, 2019

Like I mentioned , I did see same error failure in my PRs few times in the past.
I think we can merge it adding a note on this test case.

selansen
selansen approved these changes Apr 1, 2019
View reviewed changes
Copy link
Collaborator

@selansen selansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .

@kylewuolle kylewuolle mentioned this pull request Apr 12, 2019
Merged
@kylewuolle
Copy link
Contributor

ping @mavenugo @euanh !

@mavenugo mavenugo merged commit 6eca140 into moby:bump_18.03 Apr 15, 2019
@thaJeztah thaJeztah deleted the 18.03_backport_fix_agent_init_problem branch April 18, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selansen selansen selansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @selansen @kylewuolle @mavenugo