Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver: less debug #2475

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

resolver: less debug #2475

wants to merge 2 commits into from

Commits on Nov 18, 2019

  1. resolver: less debug

    Observed lots of debug messages from resolver (and associated high CPU
    usage because of lots of logging) when debug logging is turned on. Here
    is some data from a real system:
    
    > $ journalctl -u docker --since="2019-10-21 21:00:00"  --until="2019-10-21 22:00:00"  | wc -l
    > 188621
    > $ journalctl -u docker --since="2019-10-21 21:00:00"  --until="2019-10-21 22:00:00"  | grep -E 'Name To resolve: |\[resolver\] ' | wc -l
    > 186319
    
    So, it was about 200000 lines logger for just one hour, and about 99%
    of that are from resolver. While this might be the peculiarity of
    a particular setup, the number of such messages still seem way too
    excessive.
    
    Remove the ones that are not errors. In case those are needed, one have
    to recompile this package with debug_log build tag.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    c5aec55 View commit details
    Browse the repository at this point in the history
  2. More logs cleanup

    Use more `debugf` in places that look definitely like developer's debug
    which is most probably useless to an end user.
    
    Promote some debug errors that looks more like warnings to use Warnf
    rather than Debugf.
    
    Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
    kolyshkin committed Nov 18, 2019
    Configuration menu
    Copy the full SHA
    0f20b88 View commit details
    Browse the repository at this point in the history