Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose dangling filter false to be not same as the meaning of disable filter #19153

Closed
HackToday opened this issue Jan 7, 2016 · 2 comments
Closed
Labels
kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.
Milestone

Comments

@HackToday
Copy link
Contributor

Right now, the dangling filter in docker images or volumes means as following:

When dangling=true, it would just filter those images with "none"
Like this:
$ docker images -f dangling=true
REPOSITORY TAG IMAGE ID CREATED SIZE
cb70b4991cfd 16 minutes ago 133.9 MB

But when dangling=false

$ docker images -f dangling=false
REPOSITORY TAG IMAGE ID CREATED SIZE
cb70b4991cfd 17 minutes ago 133.9 MB
centos latest 61b442687d68 13 days ago 196.6 MB

It is same as docker images:

$ docker images
REPOSITORY TAG IMAGE ID CREATED SIZE
cb70b4991cfd 18 minutes ago 133.9 MB
centos latest 61b442687d68 13 days ago 196.6 MB

It seems it is very confusing, I think following maybe more meaningful:
If dangling=true it means just filter out those "none" images
if dangling=false, it means just filter out images without "none"
If without dangling filter, it means not use filter, so all images(include "none" would be listed)

It maybe more meaningful this way.

I just create this issue for discussion if it is meaningful for this propose

@HackToday
Copy link
Contributor Author

ping @cpuguy83 and @thaJeztah and @calavera Wdyt ? Thanks

@thaJeztah thaJeztah added the kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. label Jan 7, 2016
@thaJeztah
Copy link
Member

Yes, I think that makes sense!

HackToday pushed a commit to HackToday/docker that referenced this issue Jan 14, 2016
This is related image fix for Propose moby#19153
for volume related change, would use another patch
to fix that.

Signed-off-by: Kai Qiang Wu(Kennan) <wkqwu@cn.ibm.com>
@thaJeztah thaJeztah added this to the 1.10.0 milestone Jan 26, 2016
aditirajagopal pushed a commit to aditirajagopal/docker that referenced this issue Feb 8, 2016
This is related image fix for Propose moby#19153
for volume related change, would use another patch
to fix that.

Signed-off-by: Kai Qiang Wu(Kennan) <wkqwu@cn.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.
Projects
None yet
Development

No branches or pull requests

2 participants