-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not return "<unknown>" in /info response #37472
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
||
[Docker Engine API v1.39](https://docs.docker.com/engine/api/v1.39/) documentation | ||
|
||
* `GET /info` now returns an empty string, instead of `<unknown>` for `KernelVersion` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we don't explicitly document the <unknown>
value, so perhaps this is all not needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
Codecov Report
@@ Coverage Diff @@
## master #37472 +/- ##
=========================================
Coverage ? 34.95%
=========================================
Files ? 610
Lines ? 44883
Branches ? 0
=========================================
Hits ? 15689
Misses ? 27074
Partials ? 2120 |
ping @tiborvass PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll do a self-five here, as it has two LGTM's an CI is green (ignoring codecov) |
The
<unknown>
string is presentation, and should be created by the CLI (if desirable); follow-up to #37451