raftpb.ConfChange also include ConfChangeUpdateNode #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixiaobing1
force-pushed
the
masterRaft2
branch
from
c35ce55
to
21fec64
Compare
Current coverage is 55.93% (diff: 0.00%)@@ master #1711 diff @@
==========================================
Files 93 93
Lines 14782 14782
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 8260 8268 +8
+ Misses 5436 5430 -6
+ Partials 1086 1084 -2
|
| @@ -1689,7 +1689,7 @@ func getIDs(snap *raftpb.Snapshot, ents []raftpb.Entry) []uint64 { | |||
| case raftpb.ConfChangeUpdateNode: | |||
| // do nothing | |||
| default: | |||
| log.L.Panic("ConfChange Type should be either ConfChangeAddNode or ConfChangeRemoveNode!") | |||
| log.L.Panic("ConfChange Type should be either ConfChangeAddNode,or ConfChangeRemoveNode,or ConfChangeUpdateNode!") | |||
There was a problem hiding this comment.
Add spaces after the commas.
lixiaobing1
force-pushed
the
masterRaft2
branch
from
a2285d9
to
661128f
Compare
|
ok, has been modified:) |
Signed-off-by: lixiaobing10051267 <li.xiaobing1@zte.com.cn>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raftpb.ConfChange also include ConfChangeUpdateNode, log info should add this type.