Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manager: Fix hanging Stop method #2203

Merged
merged 1 commit into from
May 25, 2017
Merged

manager: Fix hanging Stop method #2203

merged 1 commit into from
May 25, 2017

Commits on May 24, 2017

  1. manager: Fix hanging Stop method 

    If raftNode.JoinAndStart failed, Stop will block forever because it
waits for the manager to start up.

To fix this, close the "started" channel even if Run exits early due to
an error. Fix the way the collector is initialized so its Stop method
won't hang either.

Add a test that makes sure the node shuts down cleanly after a failed
manager initialization.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
    @aaronlehmann
    aaronlehmann committed May 24, 2017
    Configuration menu
    Copy the full SHA
    cc882cf View commit details
    Browse the repository at this point in the history