Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.12] [manager/dispatcher] Synchronize Dispatcher.Stop() with incoming rpcs. #2522

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

anshulpundir
Copy link
Contributor

git cherry-pick 6b163ff
Cherry pick was clean.

@andrewhsu
Copy link
Member

@anshulpundir needs -x flag for cherry-pick:

$ git cherry-pick -s -x 6b163ff

(cherry picked from commit 6b163ff)

Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
@codecov
Copy link

codecov bot commented Feb 21, 2018

Codecov Report

Merging #2522 into bump_v17.12 will decrease coverage by 5.5%.
The diff coverage is 85.18%.

@@               Coverage Diff               @@
##           bump_v17.12    #2522      +/-   ##
===============================================
- Coverage        67.27%   61.76%   -5.51%     
===============================================
  Files               80      129      +49     
  Lines            11488    21247    +9759     
===============================================
+ Hits              7728    13124    +5396     
- Misses            2969     6709    +3740     
- Partials           791     1414     +623

Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when jobs are green

@dperny
Copy link
Collaborator

dperny commented Feb 21, 2018

LGTM.

@dperny dperny merged commit 9ca2583 into moby:bump_v17.12 Feb 21, 2018
@andrewhsu
Copy link
Member

For reference, this is a backport of PR:

@thaJeztah thaJeztah changed the title [manager/dispatcher] Synchronize Dispatcher.Stop() with incoming rpcs. [17.12] [manager/dispatcher] Synchronize Dispatcher.Stop() with incoming rpcs. Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants