Return correct error-codes on conflicting names #2779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
fix_api_error_types
branch
2 times, most recently
from
fc8b95f
to
08090b0
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix_api_error_types
branch
from
08090b0
to
2061af7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2779 +/- ##
==========================================
- Coverage 61.93% 61.91% -0.03%
==========================================
Files 137 137
Lines 22057 22063 +6
==========================================
- Hits 13662 13660 -2
- Misses 6918 6932 +14
+ Partials 1477 1471 -6 |
|
LGTM |
|
Thanks! |
|
relates to moby/moby#38142 |
This was referenced Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses moby/moby#38140. Relates to moby/moby#38142